Skip to content

Use assert_type to check for type inference failures for actor endpoints #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

zdevito
Copy link
Contributor

@zdevito zdevito commented Jul 11, 2025

Stack from ghstack (oldest at bottom):

This requires running pyright on the file in the oss test because pyre doesn't seem to care about the assert_type statement.

Differential Revision: D78185660

This requires running pyright on the file in the oss test because pyre doesn't seem to care about the assert_type statement.

Differential Revision: [D78185660](https://our.internmc.facebook.com/intern/diff/D78185660/)

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Jul 11, 2025
This requires running pyright on the file in the oss test because pyre doesn't seem to care about the assert_type statement.

Differential Revision: [D78185660](https://our.internmc.facebook.com/intern/diff/D78185660/)

ghstack-source-id: 295727659
Pull Request resolved: #515
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 11, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78185660

…ctor endpoints"

This requires running pyright on the file in the oss test because pyre doesn't seem to care about the assert_type statement.

Differential Revision: [D78185660](https://our.internmc.facebook.com/intern/diff/D78185660/)

[ghstack-poisoned]
zdevito added a commit that referenced this pull request Jul 11, 2025
Pull Request resolved: #515

This requires running pyright on the file in the oss test because pyre doesn't seem to care about the assert_type statement.
ghstack-source-id: 295765471

Differential Revision: [D78185660](https://our.internmc.facebook.com/intern/diff/D78185660/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78185660

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 54471df.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants